[PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

Stephen Rothwell sfr at canb.auug.org.au
Sat Oct 31 16:32:59 EST 2009


Hi Wolfram,

On Fri, 30 Oct 2009 20:44:12 +0100 Wolfram Sang <w.sang at pengutronix.de> wrote:
>
>  static struct of_platform_driver mpc52xx_psc_spi_of_driver = {
>  	.owner = THIS_MODULE,
> -	.name = "mpc52xx-psc-spi",
> +	.name = DRIVER_NAME,

You no longer need to set either owner or name in the of_platform driver,
just in the included struct driver (as is done below), so you could just
remove the above two lines.

>  	.match_table = mpc52xx_psc_spi_of_match,
>  	.probe = mpc52xx_psc_spi_of_probe,
>  	.remove = __exit_p(mpc52xx_psc_spi_of_remove),
>  	.driver = {
> -		.name = "mpc52xx-psc-spi",
> +		.name = DRIVER_NAME,
>  		.owner = THIS_MODULE,
>  	},
>  };

I am hoping that we can remove the owner and name fields from struct
of_platform_driver sometime.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20091031/c776b8f7/attachment.pgp>


More information about the Linuxppc-dev mailing list