[PATCH] powerpc: Fix compile errors found by new ppc64e_defconfig

Benjamin Herrenschmidt benh at kernel.crashing.org
Mon Oct 19 15:24:07 EST 2009


On Mon, 2009-10-19 at 10:58 +1100, Michael Ellerman wrote:

> >  	if (bus->self) {
> > +#ifdef CONFIG_PPC_STD_MMU_64
> >  		struct resource *res = bus->resource[0];
> > +#endif
> >  
> >  		pr_debug("IO unmapping for PCI-PCI bridge %s\n",
> >  			 pci_name(bus->self));
> 104 
> 105 #ifdef CONFIG_PPC_STD_MMU_64                                                
> 106                 __flush_hash_table_range(&init_mm, res->start + _IO_BASE,
> 107                                          res->end + _IO_BASE + 1);
> 108 #endif
> 109		return 0;
> 110	 }
> 
> So just expand the ifdef around the pr_debug()?

I'd rather move the pr_debug to after the ifdef, it doesn't need to
absolutely be before the __flush_hash_* call, it's more to see in the
log whether the bus was properly unmapped when doing unplug.

Cheers,
Ben.



More information about the Linuxppc-dev mailing list