[PATCH 2/8] bitmap: Introduce bitmap_set, bitmap_clear, bitmap_find_next_zero_area
akinobu.mita at gmail.com
Sun Oct 18 02:42:04 EST 2009
>> >> --- a/lib/iommu-helper.c
>> >> +++ b/lib/iommu-helper.c
>> >> @@ -19,7 +19,7 @@ again:
>> >> index = (index + align_mask) & ~align_mask;
>> >> end = index + nr;
>> >> - if (end >= size)
>> >> + if (end > size)
>> > I think that this is intentional; the last byte of the limit doesn't
>> > work.
>> It looks ok to me. Without above change, find_next_zero_area cannot
>> find a 64 bits zeroed area in next sample code.
> I meant that we don't want to find such area for IOMMUs (IIRC, it code
> came from POWER IOMMU).
OK, I see. I think we need the comment about it.
So we cannot replace find_next_zero_area by bitmap_find_next_zero_area
and current -mmotm has the bug introduced by this patch in iommu-helper
and I also introduced the bug in bitmap_find_next_zero_area if
align_mask != 0 in
Andrew, please drop
I'll overhaul the patchset and retry again.
More information about the Linuxppc-dev