[PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error

Wolfgang Grandegger wg at grandegger.com
Thu Oct 15 06:11:03 EST 2009


Grant Likely wrote:
> From: John Bonesio <bones at secretlab.ca>
> 
> The MDIO bus cannot be accessed at interrupt context, but on an FEC
> error, the fec_mpc52xx driver reset function also tries to reset the
> PHY.  Since the error is detected at IRQ context, and the PHY functions
> try to sleep, the kernel ends up panicking.
> 
> Resetting the PHY on an FEC error isn't even necessary.  This patch
> solves the problem by removing the PHY reset entirely.

There is also no need to free and re-allocate the RX buffers in
mpc52xx_fec_reset().

Wolfgang.


More information about the Linuxppc-dev mailing list