[Patch] powerpc: Fix memory leak in axon_msi.c

Michael Ellerman michael at ellerman.id.au
Tue Oct 13 11:29:40 EST 2009

cppcheck found a memory leak in axon_msi, if dcr_base or dcr_len are zero,
we have already allocated msic, so we should free it in the error path.

Signed-off-by: Eric Sesterhenn <eric.sesterhenn at lsexperts.de>
Acked-by: Michael Ellerman <michael at ellerman.id.au>

--- linux/arch/powerpc/platforms/cell/axon_msi.c.orig	2009-10-12 14:48:26.000000000 +0200
+++ linux/arch/powerpc/platforms/cell/axon_msi.c	2009-10-12 14:48:52.000000000 +0200
@@ -365,7 +365,7 @@ static int axon_msi_probe(struct of_devi
 		       "axon_msi: couldn't parse dcr properties on %s\n",
-		goto out;
+		goto out_free_msic;

 	msic->dcr_host = dcr_map(dn, dcr_base, dcr_len);

More information about the Linuxppc-dev mailing list