[RFC PATCH 02/19] powerpc: gamecube: device tree

[Segher Boessenkool]

>>> +       soc {
>>
>> It would be better to rename this as IMMR or the bus type.  This node
>> doesn't actually describe the entire chip, but describes the internal
>> memory mapped registers.
>
> I would really just call it "flipper" :-)

Yeah, I came to the same conclusion.

>> Since you're only doing 1:1 mappings; you could replace this with an
>> empty "ranges;" property instead.
>
> On the other hand it is a useful "documentation" to specify the exact
> range decoded when you know it :-)

Not the "decoded" range in this case, that is 0..4G :-)  The "canonical"
ranges is nice doc, yes.

>> Hint:  If you move the interrupt-parent property up to the root node,
>> then you don't need to specify it in every single device node; it  
>> will
>> just inherit from the parent.
>
> Note that this is a linux-ism no ? (aka ePAPRism).

Nope, it is from the standard interrupt mapping recommended practice.
It is fine.

> If they aim toward having a real OF which I think they do

We do.


Segher