[RFC PATCH 09/19] powerpc: gamecube/wii: udbg support for usbgecko

[Segher Boessenkool]

>>> +      If you say yes to this option, support will be included  
>>> for the
>>> +      USB Gecko adapter as an udbg console.
>>> +      The USB Gecko is a EXI to USB Serial converter that can be  
>>> plugged
>>> +      into a memcard slot in the Nintendo GameCube/Wii.
>>
>> Not "a" memcard slot, only the first one, you have it hardcoded.
>>
>
> No. It's not hardcoded in the code. It's specified in the device  
> tree source.
> The hardcoded one is just the early udbg, not the "normal" udbg.

Ah I misread the code then.

>> Surely there is something called something like  
>> of_node_is_compatible()
>> you can use here?  You already have the node pointer, there is no  
>> need
>> to look at all other nodes.
>>
>
> I see the point.
> I didn't find of_node_is_compatible() but I'll look what's  
> available here.

int of_device_is_compatible(const struct device_node *device,
                 const char *compat)


Segher