Bug in drivers/serial/of_serial.c?

[John Linn]

NAK also.

Yes we can generate a different device tree to fix this issue.

Thanks,
John

> -----Original Message-----
> From: Stephen Neuendorffer
> Sent: Thursday, November 19, 2009 10:23 AM
> To: Alon Ziv; Arnd Bergmann; linuxppc-dev at lists.ozlabs.org
> Cc: John Linn; grant.likely at secretlab.ca
> Subject: RE: Bug in drivers/serial/of_serial.c?
> 
> 
> NAK.
> 
> If the problem is in the device trees that are being generated, we
should fix the issue there.
> We've been trying to avoid putting the fully specified IP versions in
the kernel like this, since
> the IP changes so often.
> 
> Steve
> 
> > -----Original Message-----
> > From:
linuxppc-dev-bounces+stephen=neuendorffer.name at lists.ozlabs.org
[mailto:linuxppc-dev-
> > bounces+stephen=neuendorffer.name at lists.ozlabs.org] On Behalf Of
Alon Ziv
> > Sent: Thursday, November 19, 2009 5:49 AM
> > To: Arnd Bergmann; linuxppc-dev at lists.ozlabs.org
> > Subject: RE: Bug in drivers/serial/of_serial.c?
> >
> > On Thursday, November 19, 2009, Arnd Bergmann wrote:
> > > I'd still add support for the compatible="ns16550a" property
> > > so that we do the right thing for future systems.
> > >
> >
> > OK...
> > ---
> > Xilinx 16550 UART is actually 16550A-compatible
> >
> > Signed-off-by: Alon Ziv <alonz at discretix.com>
> >
> > diff --git a/drivers/serial/of_serial.c b/drivers/serial/of_serial.c
> > index 02406ba..241be77 100644
> > --- a/drivers/serial/of_serial.c
> > +++ b/drivers/serial/of_serial.c
> > @@ -161,7 +161,9 @@ static int of_platform_serial_remove(struct
> > of_device *ofdev)
> >  static struct of_device_id __devinitdata of_platform_serial_table[]
= {
> >  	{ .type = "serial", .compatible = "ns8250",   .data = (void
> > *)PORT_8250, },
> >  	{ .type = "serial", .compatible = "ns16450",  .data = (void
> > *)PORT_16450, },
> > +	{ .type = "serial", .compatible = "xlnx,xps-uart16550-2.00.b",
> > .data = (void *)PORT_16550A, },
> >  	{ .type = "serial", .compatible = "ns16550",  .data = (void
> > *)PORT_16550, },
> > +	{ .type = "serial", .compatible = "ns16550a", .data = (void
> > *)PORT_16550A, },
> >  	{ .type = "serial", .compatible = "ns16750",  .data = (void
> > *)PORT_16750, },
> >  	{ .type = "serial", .compatible = "ns16850",  .data = (void
> > *)PORT_16850, },
> >  #ifdef CONFIG_SERIAL_OF_PLATFORM_NWPSERIAL
> >
************************************************************************
**********************
> > IMPORTANT: The contents of this email and any attachments are
confidential. They are intended for
> the
> > named recipient(s) only.
> > If you have received this email in error, please notify the system
manager or the sender
> immediately
> > and do
> > not disclose the contents to anyone or make copies thereof.
> >
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev at lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.