[PATCH] ibm_newemac: Fix EMACx_TRTR[TRT] bit shifts

Dave Mitchell dmitchell at appliedmicro.com
Wed Nov 18 11:56:55 EST 2009


The TRT bit shifts were reversed for EMAC4 and non-EMAC4 during the 
port from ibm_emac to ibm_newemac. This patch corrects that error.

Signed-off-by: Dave Mitchell <dmitchell at appliedmicro.com>
Acked-by: Feng Kan <fkan at appliedmicro.com>
Acked-by: Prodyut Hazarika <phazarika at appliedmicro.com>
---
 For those curious, these bits control the TX threshold.
 
 drivers/net/ibm_newemac/emac.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ibm_newemac/emac.h b/drivers/net/ibm_newemac/emac.h
index d34adf9..f2751cb 100644
--- a/drivers/net/ibm_newemac/emac.h
+++ b/drivers/net/ibm_newemac/emac.h
@@ -263,8 +263,8 @@ struct emac_regs {
 
 
 /* EMACx_TRTR */
-#define EMAC_TRTR_SHIFT_EMAC4		27
-#define EMAC_TRTR_SHIFT			24
+#define EMAC_TRTR_SHIFT_EMAC4		24
+#define EMAC_TRTR_SHIFT		27
 
 /* EMAC specific TX descriptor control fields (write access) */
 #define EMAC_TX_CTRL_GFCS		0x0200
-- 
1.6.3.2



More information about the Linuxppc-dev mailing list