[PATCH] net/can: add driver for mscan family & mpc52xx_mscan

Wolfram Sang w.sang at pengutronix.de
Tue Nov 17 05:44:16 EST 2009


Hi Grant,

Wolfgang commented on some points already, I will pick up the other remarks,
just one question:

> > +       clk_src = of_get_property(np, "fsl,mscan-clk-src", NULL);
> > +       if (clk_src && strcmp(clk_src, "ip") == 0)
> 
> Should protect against non-null.  strncmp() maybe?

"ip" is null-terminated, or what do you mean?

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20091116/e96fee89/attachment.pgp>


More information about the Linuxppc-dev mailing list