[PATCH 2/4] xilinx_spi: Switch to iomem functions and support little endian.

Grant Likely grant.likely at secretlab.ca
Thu Nov 12 08:09:23 EST 2009

On Wed, Nov 11, 2009 at 7:38 AM, Richard Röjfors
<richard.rojfors at mocean-labs.com> wrote:
> This patch changes the out_(be)(8|16|32) and in_(be)(8|16|32) calls to iowrite(8|16|32)
> and ioread(8|16|32). This to be able to build on platforms not supporting the in/out calls
> for instance x86.

As discussed previously, I'd rather see as an ops table instead of as
if/else in each accessor, but I won't push it unless I hear the same
opinion from others.  John what do you think?  (But if it should be an
ops table, then I want it done now so that we don't end up with
another just as invasive patch to change the form yet again in 6
months time).

Otherwise looks good to me on brief read-through.


Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

More information about the Linuxppc-dev mailing list