[PATCH RFC] gianfar: Do not call skb recycling with disabled IRQs

David Miller davem at davemloft.net
Sun Nov 8 20:08:48 EST 2009


From: Anton Vorontsov <avorontsov at ru.mvista.com>
Date: Thu, 5 Nov 2009 19:57:38 +0300

> But that basically means that with skb recycling we can't safely
> use KGDBoE, though we can add something like this:

Please stop adding special logic only to your driver to handle these
things.

Either it's a non-issue, or it's going to potentially be an issue for
everyone using skb_recycle_check() in a NAPI driver, right?

So why not add the "in_interrupt()" or whatever check to
skb_recycle_check() and if the context is unsuitable return false (0)
ok?


More information about the Linuxppc-dev mailing list