[PATCH] [SCSI] mpt fusion: Fix 32 bit platforms with 64 bit resources.

Josh Boyer jwboyer at linux.vnet.ibm.com
Fri Nov 6 03:25:01 EST 2009


On Thu, Nov 05, 2009 at 10:07:06AM -0600, James Bottomley wrote:
>On Thu, 2009-11-05 at 08:43 -0500, Josh Boyer wrote:
>> On Tue, Sep 15, 2009 at 03:25:55PM -0700, pbathija at amcc.com wrote:
>> >From: Pravin Bathija <pbathija at amcc.com>
>> >
>> >Powerpc 44x uses 36 bit real address while the real address defined
>> >in MPT Fusion driver is of type 32 bit. This causes ioremap to fail and driver
>> >fails to initialize. This fix changes the data types representing the real
>> >address from unsigned long 32-bit types to "phys_addr_t" which is 64-bit. The
>> >driver has been tested, the disks get discovered correctly and can do IO. Also,
>> >replaced phys_addr_t with resource_size_t as suggested by Ben.
>> >
>> >Signed-off-by: Pravin Bathija <pbathija at amcc.com>
>> >Acked-by: Feng Kan <fkan at amcc.com>
>> >Acked-by: Prodyut Hazarika <phazarika at amcc.com>
>> >Acked-by: Loc Ho <lho at amcc.com>
>> >Acked-by: Tirumala Reddy Marri <tmarri at amcc.com>
>> >Acked-by: Victor Gallardo <vgallardo at amcc.com>
>> 
>> Is this patch included in the scsi tree at all?  I can't seem to find it in
>> linux-next and I know it's not in the powerpc tree.  Are there further changes
>> needed, or has it simply been missed?
>
>What was the feedback from LSI ... I haven't seen any here?

I've seen no feedback on it anywhere.  The original patch used both
phys_addr_t and resource_size_t and Ben suggested they just use resource_size_t
everywhere.  Pravin reposted (which is this current patch) and it has sat here
since then.

josh


More information about the Linuxppc-dev mailing list