[PATCH] powerpc:beyond ARRAY_SIZE of args.args

Paul Mackerras paulus at samba.org
Fri May 22 09:10:36 EST 2009


Roel Kluin writes:

> Do not go beyond ARRAY_SIZE of args.args
> 
> Signed-off-by: Roel Kluin <roel.kluin at gmail.com>
> ---
> I'm quite sure the first is correct, but should maybe `args.nret'
> and `nargs + args.nret' also be `>= ARRAY_SIZE(args.args)'?

I don't think this change is needed, and it changes a user-visible
API, so I'm nacking it unless you can convince me there's really a
problem.

If nargs == ARRAY_SIZE(args.args), then args.nret must be zero, so
nothing will access *(args.rets).

Paul.



More information about the Linuxppc-dev mailing list