[PATCH 3/6] powerpc: add memory map support to Freescale RapidIO block
Li Yang
leoli at freescale.com
Thu May 21 20:43:23 EST 2009
On Wed, May 13, 2009 at 6:05 AM, Andrew Morton
<akpm at linux-foundation.org> wrote:
> On Tue, 12 May 2009 16:36:00 +0800
> Li Yang <leoli at freescale.com> wrote:
>
>> + align = (size < 0x1000) ? 0x1000 : 1 << (__ilog2(size - 1) + 1);
>> +
>> + /* Align the size */
>> + if ((lstart + size) > (_ALIGN_DOWN(lstart, align) + align)) {
>
> __ilog2() and _ALIGN_DOWN() are powerpc-specific functions. It would
> be preferable to use more general helpers if possible. ALIGN() and ilog2()
> might suit here.
Will change to use ilog2().
_ALIGN_DOWN() gets a lower aligned address while ALIGN() gets a higher
address. It seems that we don't have a general helper to do the same.
- Leo
More information about the Linuxppc-dev
mailing list