[PATCH] powerpc/pcm030.dts: add i2c eeprom and delete cruft

[Grant Likely]

On Wed, May 20, 2009 at 10:25 AM, Grant Likely
<grant.likely at secretlab.ca> wrote:
> On Wed, May 20, 2009 at 10:15 AM, Wolfram Sang <w.sang at pengutronix.de> wrote:
>> On Wed, May 20, 2009 at 12:10:59PM -0400, Jon Smirl wrote:
>>> On Wed, May 20, 2009 at 11:53 AM, Wolfram Sang <w.sang at pengutronix.de> wrote:
>>> >> > -                       /* FIXME: EEPROM */
>>> >> > +                       eeprom at 52 {
>>> >> > +                               compatible = "at24,24c32";
>>> >> > +                               reg = <0x52>;
>>> >> > +                       };
>>> >>
>>> >> Grant suggested this earlier...
>>> >>                       eeprom at 52 {
>>> >>                               compatible = "atmel,24c32", "eeprom";
>>> >>                               reg = <0x52>;
>>> >>                       };
>>> >
>>> > Can you give me a pointer? I just found this thread
>>>
>>>
>>> Grant, what do you want here?
>>
>> I fear an answer like: "a properly working at24" ;)
>>
>
> BWAHAHAHAHA!

Now that I've got that out of the way...

As the other thread states, "eeprom" is far too vague, and it is
certainly not documented, and does not say anything meaningful about
the protocol used to talk to the eeprom.  Sure, most i2c eeproms use
the same protocol, but an assumption cannot be made that that will
always be the case.  Plus, the namespace will collide with non-i2c
eeproms.  "i2c-eeprom" is better, but not great.  Before a value like
"i2c-eeprom" can be acceptable, it must be documented and reviewed as
to exactly what it means, and even then I'm uncomfortable with it.

However, on the other point, Jon is correct.  The first value in the
list should be "atmel,24c32", not "at24,24c32".

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.