[PATCH] Allow selecting mv643xx_eth on Pegasos again

[Medve Emilian-EMMEDVE1]

Hello Gabriel,


> -----Original Message-----
> From: Gabriel Paubert [mailto:paubert at iram.es]
> Sent: Monday, May 18, 2009 1:48 PM
> To: Medve Emilian-EMMEDVE1
> Cc: Lennert Buytenhek; tbm at cyrius.com; LinuxPPC; pacman at kosh.dhis.org;
netdev at vger.kernel.org; David
> Miller
> Subject: Re: [PATCH] Allow selecting mv643xx_eth on Pegasos again
> 
> On Mon, May 18, 2009 at 10:48:58AM -0700, Medve Emilian-EMMEDVE1
wrote:
> > > -----Original Message-----
> > > From: linuxppc-dev-bounces+emilian.medve=freescale.com at ozlabs.org
> > [mailto:linuxppc-dev-
> > > bounces+emilian.medve=freescale.com at ozlabs.org] On Behalf Of
Gabriel
> > Paubert
> > > Sent: Monday, May 18, 2009 12:38 PM
> > > To: Lennert Buytenhek
> > > Cc: tbm at cyrius.com; LinuxPPC; pacman at kosh.dhis.org;
> > netdev at vger.kernel.org; David Miller
> > > Subject: [PATCH] Allow selecting mv643xx_eth on Pegasos again
> > >
> > > Since PPC_MUTIPLATFORM was removed, it was impossible to select
the
> > > driver for mv643xx_eth on the Pegasos. Fix by allowing to select
> > > the driver on CHRP platforms; Pegasos is a CHRP platform and the
> > driver
> > > will not work without arch/powerpc/platforms/chrp/pegasos_eth.
> > >
> > > Signed-off-by: Gabriel Paubert <paubert at iram.es>
> > >
> > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > > index 214a92d..6fc0ff4 100644
> > > --- a/drivers/net/Kconfig
> > > +++ b/drivers/net/Kconfig
> > > @@ -2351,7 +2351,7 @@ config UGETH_TX_ON_DEMAND
> > >
> > >  config MV643XX_ETH
> > >  	tristate "Marvell Discovery (643XX) and Orion ethernet support"
> > > -	depends on MV64360 || MV64X60 || (PPC_MULTIPLATFORM && PPC32) ||
> > PLAT_ORION
> > > +	depends on MV64X60 || PPC_CHRP || PLAT_ORION
> > >  	select INET_LRO
> > >  	select PHYLIB
> > >  	help
> >
> > This got fixed here:
> >
http://git.kernel.org/?p=linux/kernel/git/davem/net-next-2.6.git;a=commi
> > tdiff;h=952ee9df26c487f2d73b2dced58ec904f19ea0f8
> 
> Ok, I was not aware of it, but the fact is that MV64360 no more exists
> and the only non MV64X60 platform that may need it is the Pegasos (to
my
> knowledge) and it relies on some platform specific code enabled
> by PPC_CHRP.

You're correct. MV64360 seems to be stale. Do you want to re-spin your
patch to get rid of it?

(I wouldn't create a dependency between MV643XX_ETH and PPC_CHRP.)
 

Cheers,
Emil.