[Linux-fbdev-devel] [PATCH] fbdev: Add PLB support and cleanup DCR in xilinxfb driver.

[Geert Uytterhoeven]

On Sun, May 17, 2009 at 10:06, Krzysztof Helt <krzysztof.h1 at poczta.fm> wrote:
> On Fri, 15 May 2009 12:19:17 -0600 Grant Likely <grant.likely at secretlab.ca> wrote:
>> diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c
>> index 40a3a2a..7a868bd 100644
>> --- a/drivers/video/xilinxfb.c
>> +++ b/drivers/video/xilinxfb.c
>> @@ -107,17 +111,28 @@ static struct fb_var_screeninfo xilinx_fb_var = {
>>       .activate =     FB_ACTIVATE_NOW
>>  };
>>
>> +
>> +#define PLB_ACCESS_FLAG      0x1             /* 1 = PLB, 0 = DCR */
>> +
>>  struct xilinxfb_drvdata {
>>
>>       struct fb_info  info;           /* FB driver info record */
>>
>> -     u32             regs_phys;      /* phys. address of the control registers */
>> -     u32 __iomem     *regs;          /* virt. address of the control registers */
>> +     phys_addr_t     regs_phys;      /* phys. address of the control
>> +                                             registers */
>
> There are fields fb_info.fix.mmio_start and fb_info.fix.mmio_len for
> physical IO range used by framebuffer. There is no field for
> virtual IO address so the "regs" below must stay.

If I'm not mistaken, this driver is used on ppc44x, where phys_addr_t is 64-bit,
so the 32-bit unsigned long fb_info.fix.mmio_start is not large enough
to hold the
physical address.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds