[PATCH] mpc5121/clocks: make debug output more readable
Grant Likely
grant.likely at secretlab.ca
Sat May 9 01:40:08 EST 2009
On Fri, May 8, 2009 at 6:34 AM, Wolfram Sang <w.sang at pengutronix.de> wrote:
>
> - Drop KERN_ levels for printks which print to the same line
> - use '=' in output to connect key/value pairs
Personally, I'd rather see the printks converted to pr_info()/pr_cont().
g.
>
> Signed-off-by: Wolfram Sang <w.sang at pengutronix.de>
> Cc: John Rigby <jcrigby at gmail.com>
> Cc: Grant Likely <grant.likely at secretlab.ca>
>
> ---
> arch/powerpc/platforms/512x/clock.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> Index: .kernel/arch/powerpc/platforms/512x/clock.c
> ===================================================================
> --- .kernel.orig/arch/powerpc/platforms/512x/clock.c
> +++ .kernel/arch/powerpc/platforms/512x/clock.c
> @@ -83,12 +83,11 @@ static void dump_clocks(void)
> mutex_lock(&clocks_mutex);
> printk(KERN_INFO "CLOCKS:\n");
> list_for_each_entry(p, &clocks, node) {
> - printk(KERN_INFO " %s %ld", p->name, p->rate);
> + printk(KERN_INFO " %s=%ld", p->name, p->rate);
> if (p->parent)
> - printk(KERN_INFO " %s %ld", p->parent->name,
> - p->parent->rate);
> + printk(" %s=%ld", p->parent->name, p->parent->rate);
> if (p->flags & CLK_HAS_CTRL)
> - printk(KERN_INFO " reg/bit %d/%d", p->reg, p->bit);
> + printk(" reg/bit=%d/%d", p->reg, p->bit);
> printk("\n");
> }
> mutex_unlock(&clocks_mutex);
>
> --
> Pengutronix e.K. | Wolfram Sang |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkoEJsUACgkQD27XaX1/VRuQggCgm7auPJpCpTVleUD30B86X/jW
> lZsAnR91XB0YVCBp95aGyEqUU8+LXaHv
> =6IcQ
> -----END PGP SIGNATURE-----
>
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
More information about the Linuxppc-dev
mailing list