[PATCH 06/12] mpc5121: Added NAND Flash Controller driver.

Grant Likely grant.likely at secretlab.ca
Fri May 8 13:07:58 EST 2009


On Thu, May 7, 2009 at 8:22 PM, John Rigby <jcrigby at gmail.com> wrote:
>
>
> On Wed, May 6, 2009 at 2:59 PM, Grant Likely <grant.likely at secretlab.ca>
> wrote:
>>
>>
>> > diff --git a/arch/powerpc/platforms/512x/mpc512x_shared.c
>> > b/arch/powerpc/platforms/512x/mpc512x_shared.c
>> > index d8cd579..7135d89 100644
>> > --- a/arch/powerpc/platforms/512x/mpc512x_shared.c
>> > +++ b/arch/powerpc/platforms/512x/mpc512x_shared.c
>> > @@ -71,6 +71,7 @@ void __init mpc512x_init_IRQ(void)
>> >  static struct of_device_id __initdata of_bus_ids[] = {
>> >        { .compatible = "fsl,mpc5121-immr", },
>> >        { .compatible = "fsl,mpc5121-localbus", },
>> > +       { .compatible = "fsl,mpc5121-nfc", },
>>
>> This doesn't look right.  Shouldn't the NAND controller be hanging of
>> the IMMR node?
>
> I just wanted to confirm that NFC is in its own memory space.   It has its
> own mapping and is not part of the IMMR space.

Hmmm... I wonder then if it might be better to have an IPB node, and
hang all the IPB connected nodes off of it.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.



More information about the Linuxppc-dev mailing list