[PATCH] powerpc/pci: clean up direct access to sysdata by iseries platform

Stephen Rothwell sfr at canb.auug.org.au
Thu May 7 10:52:29 EST 2009


Hi Kumar,

On Wed, 6 May 2009 23:13:38 +1000 Stephen Rothwell <sfr at canb.auug.org.au> wrote:
>
> On Tue,  5 May 2009 07:04:55 -0500 Kumar Gala <galak at kernel.crashing.org> wrote:
> >
> > We shouldn't directly access sysdata to get the device node.  We should
> > be calling pci_device_to_OF_node().
> > 
> > Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> 
> It looks ok, but all I can say for now is that it doesn not make things
> worse.  During 2.6.28, the iSeries PCI code was broken.  I am working on
> a fix and after that I will be able to properly test this patch.

With my fix for the old PCI breakage, I have tested your "pci" tree for
iseries_defconfig.  Built and booted with and without CONFIG_PCI.

Tested-by: Stephen Rothwell <sfr at canb.auug.og.au>
Acked-by: Stephen Rothwell <sfr at canb.auug.og.au>

My patch, however, will probably need your attention once Ben takes
it. :-)
-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20090507/a14bce85/attachment.pgp>


More information about the Linuxppc-dev mailing list