[PATCH 02/12] fs_enet: Add MPC5121 FEC support.
Scott Wood
scottwood at freescale.com
Thu May 7 07:08:15 EST 2009
Grant Likely wrote:
>> #ifdef CONFIG_FS_ENET_HAS_FEC
>> +#ifdef CONFIG_FS_ENET_MPC5121_FEC
>> + {
>> + .compatible = "fsl,mpc5121-fec",
>> + .data = (void *)&fs_fec_ops,
>> + },
>> +#else
>> {
>> .compatible = "fsl,pq1-fec-enet",
>> .data = (void *)&fs_fec_ops,
>> },
>> #endif
>> +#endif
>
> Hmmm. A lot of these #ifdefs in here. Does this have a multiplatform
> impact? Not to mention the fact that it's just plain ugly. :-)
Multiplatform between 512x and 8xx is currently impossible for other
reasons (512x and CPM2 is another matter). That said, less ifdefs would
be nice.
-Scott
More information about the Linuxppc-dev
mailing list