[PATCH 1/2] Added support for Designware SATA controller driver

Jeff Garzik jeff at garzik.org
Sat May 2 10:05:06 EST 2009


Wolfgang Denk wrote:
> Dear Feng Kan,
> 
> In message <1241211767-32697-1-git-send-email-fkan at amcc.com> you wrote:
>> This adds support for the Designware SATA controller.
>>
>> Signed-off-by: Feng Kan <fkan at amcc.com>
>> Signed-off-by: Mark Miesfeld <miesfeld at gmail.com>
>> ---
>>  drivers/ata/Kconfig    |   10 +
>>  drivers/ata/Makefile   |    1 +
>>  drivers/ata/sata_dwc.c | 2053 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 2064 insertions(+), 0 deletions(-)
>>  create mode 100644 drivers/ata/sata_dwc.c
> 
> ...
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_AUTHOR("Mark Miesfeld <mmiesfeld at amcc.com>");
>> +MODULE_DESCRIPTION("DesignWare Cores SATA controller low lever driver");
> ------------------------------------------------------------^^^^^
> 
> Guess that's a typo?

heh


> Hmm... that's 2000+ lines of code in a single file. Maybe this should
> be split?

A single file is just fine.

	Jeff





More information about the Linuxppc-dev mailing list