[PATCH] ucc_geth: Rework the TX logic.
Joakim Tjernlund
Joakim.Tjernlund at transmode.se
Tue Mar 31 03:38:16 EST 2009
Scott Wood <scottwood at freescale.com> wrote on 27/03/2009 14:26:00:
>
> Joakim Tjernlund wrote:
> > This is a bit better than the current type casts. Moving over to qe_bd
> > accesses is a bigger cleanup that will have to be a seperate patch.
> > I am not sure it is an all win as you probably loose the ability
> > to read both status and len in one access.
>
> Not if you define the struct to have one status_len field (or a union of
> that with separate fields), as gianfar does.
gianfar does not seem to use in_/out_ functions for the BDs. Works just
fine that too it seems. I always felt that the in_/out_ functions
was extra baggage that the Freescale CPUs don't need. There is
something in between that is missing.
Jocke
More information about the Linuxppc-dev
mailing list