[PATCH] ucc_geth: Convert to net_device_ops

[Joakim Tjernlund]

David Miller <davem at davemloft.net> wrote on 23/03/2009 19:49:28:
> 
> From: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
> Date: Mon, 23 Mar 2009 11:17:39 +0100
> 
> > Sorry for the WS damaged patch, but my current company mailer cannot
> > handle inline patches. Due to this we are setting up a new mail system
> > but it will be a few days before this is ready.
> > Therefore I am attaching this patch as well, use that one
> > to apply instaed of the inline variant.
> 
> This patch has other problems, anyways.
> 
> > +#if 0
> > +/* not yet */
> > +       .ndo_set_mac_address    = ucc_geth_set_mac_address,
> > +       .ndo_change_mtu         = ucc_geth_change_mtu,
> > +       .ndo_do_ioctl           = ucc_geth_do_ioctl,
> > +#endif
> 
> Don't do stuff like this, please.  Even the code you are
> copying from doesn't have the set_mac_address method
> assignment proceted by #if 0 stuff.
> 
> Just get rid of all the unused stuff completely.

OK, here is a new version. The #if 0 ..#endif has been removed.


 Jocke
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ucc_geth-Convert-to-net_device_ops.patch
Type: application/octet-stream
Size: 1963 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20090324/890b9971/attachment.obj>