[PATCH] powerpc: Remove extra semicolon in fsl_soc.c

Grant Likely grant.likely at secretlab.ca
Thu Mar 12 03:03:22 EST 2009


On Wed, Mar 11, 2009 at 9:50 AM, Johns Daniel <johns.daniel at gmail.com> wrote:
> A semicolon at the end of the macro means that the for loop has an
> empty body, and so TSEC/MDIO will not work with older device trees.
>
> This fix only applies to 2.6.28; apparently, this code is gone for
> 2.6.29, according to Grant Likely!
>
> Signed-off-by: Johns Daniel <johns.daniel at gmail.com>

Acked-by: Grant Likely <grant.likely at secretlab.ca>

Greg:  Andy Flemming should probably confirm this, but I think this
one should be backported to the stable series.

g.

> ---
> --- linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c.orig   2009-02-20
> 16:41:27.000000000 -0600
> +++ linux-2.6.28.7/arch/powerpc/sysdev/fsl_soc.c        2009-03-10
> 15:56:47.000000000 -0500
> @@ -257,7 +257,7 @@
>                gfar_mdio_of_init_one(np);
>
>        /* try the deprecated version */
> -       for_each_compatible_node(np, "mdio", "gianfar");
> +       for_each_compatible_node(np, "mdio", "gianfar")
>                gfar_mdio_of_init_one(np);
>
>        return 0;
> ---
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.



More information about the Linuxppc-dev mailing list