[PATCH] powerpc 4xx EMAC driver: device name reported on timeout is not correct

[Mikhail Zolotaryov]

Hi,

not critical problem here.

IBM EMAC driver performs device reset (drivers/net/ibm_newemac/core.c: 
emac_probe() -> emac_init_phy() -> emac_reset()) before registering 
appropriate net_device (emac_probe() -> register_netdev()), so 
net_device name contains raw format string during EMAC reset ("eth%d").

If the case of reset timeout, emac_report_timeout_error() function is 
called to report an error. The problem is this function uses net_device 
name to report device related, which is not correct, as a result in the 
kernel log buffer we see:

eth%d: reset timeout

The solution is to print device_node full_name instead. After applying 
the patch proposed, error string is like the following:

/plb/opb/ethernet at ef600e00: reset timeout


Signed-off-by: Mikhail Zolotaryov <lebon at lebon.org.ua>


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: emac_report_timeout_error.patch
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20090310/468147ef/attachment.asc>