PHY not found after migration of gianfar driver to an of_platform_driver

Wolfgang Ocker weo at reccoware.de
Sun Mar 8 23:18:44 EST 2009


On Thu, 2009-02-26 at 20:15 +0100, Michael Guntsche wrote:
> For testing purposes I tried a recent git snapshot and noticed  
> that the gianfar driver had problems.
> While the the Gianfar was detected
> [...]
> trying to up either of the devices gave me
> 
> [    8.724818] mdio at 24520:01 not found
> [    8.728330] eth1: Could not attach to PHY
> [    8.732945] mdio at 24520:01 not found
> [    8.737720] eth1: Could not attach to PHY

I saw exactly the same symptoms on an 8560 board, and the patch below
helped. But I have no idea what's going on there ...

Wolfgang

From: Wolfgang Ocker <weo at reccoware.de>
Date: Sat, 7 Mar 2009 14:27:50 +0100
Subject: [PATCH] fsl-gianfar: improved detection of unoccupied PHY address

At least on one 8560 board the id 0x000ffff is returned at an
unoccupied PHY address.

Signed-off-by: Wolfgang Ocker <weo at reccoware.de>
---
 drivers/net/gianfar_mii.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/gianfar_mii.c b/drivers/net/gianfar_mii.c
index f49a426..9c5e0c1 100644
--- a/drivers/net/gianfar_mii.c
+++ b/drivers/net/gianfar_mii.c
@@ -211,7 +211,7 @@ static int gfar_mdio_find_free(struct mii_bus *new_bus)
 		if (get_phy_id(new_bus, i, &phy_id))
 			return -1;
 
-		if (phy_id == 0xffffffff)
+		if (phy_id == 0xffffffff || phy_id == 0x0000ffff)
 			break;
 	}
 
-- 
1.6.0.6





More information about the Linuxppc-dev mailing list