[PATCH v3 2/2] fsldma: Add DMA_SLAVE support

Kumar Gala galak at kernel.crashing.org
Tue Jun 23 22:56:25 EST 2009


On Jun 23, 2009, at 5:18 AM, Li Yang wrote:

> On Tue, Jun 23, 2009 at 5:20 AM, Dan  
> Williams<dan.j.williams at intel.com> wrote:
>> On Fri, 2009-06-19 at 12:31 -0700, Ira Snyder wrote:
>>> Use the DMA_SLAVE capability of the DMAEngine API to copy/from a
>>> scatterlist into an arbitrary list of hardware address/length pairs.
>>>
>>> This allows a single DMA transaction to copy data from several  
>>> different
>>> devices into a scatterlist at the same time.
>>>
>>> This also adds support to enable some controller-specific features  
>>> such as
>>> external start and external pause for a DMA transaction.
>>>
>>> Signed-off-by: Ira W. Snyder <iws at ovro.caltech.edu>
>>> ---
>>>
>>> This patch depends on the "fsldma: split apart external pause and
>>> request count features" patch.
>>>
>>> After discussion with Dan Williams, this is the third version of the
>>> DMA_SLAVE API for the Freescale DMA controller. I've tested it  
>>> heavily
>>> with both drivers I have written against this API, an FPGA  
>>> programmer
>>> and an FPGA data grabber.
>>>
>>> Kumar, Dan asked me to add you to the CC list, so you can have a  
>>> look at
>>> this patch before he adds it to his tree.
>>>
>>> The other two small patches I posted earlier are very helpful in  
>>> testing
>>> this functionality. They make the fsldma driver leave the BWC  
>>> (bandwidth
>>> control) bits alone on the 83xx controller, as well as making the
>>> external start feature available on 83xx.
>>>
>>
>> Kumar, Leo,
>>
>> Can I get your acked-by's for the current state of async_tx.git/ 
>> next?  I
>> just pushed out Ira's latest so it may take a moment to mirror out.
>
> Acked-by: Li Yang <leoli at freescale.com>
>
> However, the addition of arch/powerpc/include/asm/fsldma.h still needs
> the ack from Kumar.  It doesn't seem to be a common practice though.

hmm, why are we moving fsldma.h?

- k


More information about the Linuxppc-dev mailing list