[PATCH] spufs: remove redundant test on unsigned

Roel Kluin roel.kluin at gmail.com
Tue Jun 23 08:20:29 EST 2009


Unsigned `len' cannot be less than 0.

Signed-off-by: Roel Kluin <roel.kluin at gmail.com>
---
Or should it be `if (!buf || len > MAX)' and what should MAX be then?

diff --git a/arch/powerpc/platforms/cell/spufs/sputrace.c b/arch/powerpc/platforms/cell/spufs/sputrace.c
index d0b1f3f..8f799ee 100644
--- a/arch/powerpc/platforms/cell/spufs/sputrace.c
+++ b/arch/powerpc/platforms/cell/spufs/sputrace.c
@@ -73,7 +73,7 @@ static ssize_t sputrace_read(struct file *file, char __user *buf,
 {
 	int error = 0, cnt = 0;
 
-	if (!buf || len < 0)
+	if (!buf)
 		return -EINVAL;
 
 	while (cnt < len) {


More information about the Linuxppc-dev mailing list