Badness on the Warp
Sean MacLennan
smaclennan at pikatech.com
Sun Jun 21 09:42:50 EST 2009
I found the source of the badness. The backtrace is correct:
uic_init_one
___alloc_bootmem
___alloc_bootmem_nopanic
alloc_arch_preferred_bootmem
In alloc_arch_preferred_bootmem we have:
if (WARN_ON_ONCE(slab_is_available()))
return kzalloc(size, GFP_NOWAIT);
Since the slab is available (it had better be or the call will return
NULL), we get the badness message, then a successful return from
kzalloc.
I believe the author wants something like:
if (slab_is_available())
return kzalloc(size, GFP_NOWAIT);
else
WARN_ON_ONCE(1);
Cheers,
Sean
More information about the Linuxppc-dev
mailing list