[PATCH 05/04] *** NOT FOR RELEASE *** HACK *** Work around MII clock issue ***

Wolfgang Denk wd at denx.de
Mon Jun 8 18:19:04 EST 2009


Dear Wolfgang,

In message <4A2CC1DE.5040704 at grandegger.com> you wrote:
>
> > Hm... so that means on MPC512x we should use mpc512x_find_ips_freq(),
> > while on MPC5200 we should use  mpc52xx_find_ipb_freq()  -  but  hey,
> > apart from the name these two functions are identical.
> > 
> > Grant - how would you like to see this handled? Should we merge these
> > two code-wise identical functions into one?  What should be the name,
> > and in which file should we put it?
> > 
> > [We need this clock thing for "drivers/net/fs_enet/mii-fec.c"...]
> 
> I2C and MSCAN need it as well. What about implementing the more generic
> clk api for the MPC5200 as done for the MPC512x?

> http://lxr.linux.no/linux+v2.6.29/arch/powerpc/platforms/512x/clock.c

Hmmm... I have to admit that I'm biased he. My  primary  interest  at
the  moment is obviously just to get the MPC512x stuff into mainline,
and thus I'm not happy about extending the scope of the isse to other
processors.



More information about the Linuxppc-dev mailing list