[PATCH 2/2 v4] MPC52xx FEC: be more conservative when setting MII_SPEED register
wd at denx.de
Sat Jul 18 03:51:38 EST 2009
Dear Grant Likely,
In message <fa686aa40907170745h6c5fae6bia0cff0926c93393c at mail.gmail.com> you wrote:
> > drivers/net/fec_mpc52xx.c | 25 ++++++++++++++++++++++---
> > drivers/net/fec_mpc52xx_phy.c | 23 ++++++++++++++++++++---
> Blech. now this block of duplicated code I don't like. This is all
> one device, so surely the mdio speed can be calculated once and used
> for both drivers.... let me think about this for a bit. 'course this
> problem is all rolled up in the nastiness of having two drivers
> working on the same device. I suspect is was a mistake to split up
> all the powerpc ethernet drivers into separate of_platform drivers.
If you like, I can re-introduce the mpc5xxx_get_mii_speed() I unrolled
upon your request (with or without re-using it for the MPC512x case).
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What is mind? No matter. What is matter? Never mind.
-- Thomas Hewitt Key, 1799-1875
More information about the Linuxppc-dev