[PATCH 2/2] MPC52xx FEC: be more conservative when setting MII_SPEED register

Wolfgang Denk wd at denx.de
Fri Jul 17 07:21:50 EST 2009


Dear Grant Likely,

In message <fa686aa40907151018n194a154cmb8549c98c673d2bb at mail.gmail.com> you wrote:
> On Wed, Jul 15, 2009 at 9:18 AM, Wolfgang Denk<wd at denx.de> wrote:
> > This patch adds error checking and prevents clobbering unrelated bits
> > (reserved bits or the DIS_PREAMBLE bit) when writing the MII_SPEED
> > register on MPC52xx systems.
...
> As I mentioned in the other patch, I don't want the 5121 and 5200 FEC
> devices using common code for this.  It is a tiny block of code and
> they are different devices.  Just open code the needed calculation
> into this driver.

OK, will do.


More information about the Linuxppc-dev mailing list