Questions in spi_mpc83xx.c

Mark Bishop mark at bish.net
Fri Jul 10 04:16:48 EST 2009


I haven't seen this before - the '##' in the function name.  This is ANCII C?

#define MPC83XX_SPI_TX_BUF(type)				\
u32 mpc83xx_spi_tx_buf_##type(struct mpc83xx_spi *mpc83xx_spi)	\
{								\
	u32 data;						\
....


Also, I have a SPI chip here that will drive MISO high when it is  
ready to accept more data.  It acts like a hardware handshake.  I was  
thinking about making changes to the controller source (spi_mpc83xx.c,  
in my case) to support this.

This is the only SPI chip contained on this system so I am not worried  
about affecting other SPI devices hooked to the controller.

What are people's opinion on this as far as right place to implement,  
and I could use a push as to where in the controller to make mods if  
appropriate.

And if it isn't obvious already I am still learning a bit as to how  
the SPI sub-system is organized.   I have taken apart the  
documentation in the kernel Documentation/spi directory and am reading  
all the code in drivers/spi.


More information about the Linuxppc-dev mailing list