[PATCH 6/8] powerpc/5200: Remove pr_debug() from hot paths in irq driver

[Wolfram Sang]

On Wed, Jan 21, 2009 at 01:55:35PM -0700, Grant Likely wrote:
> From: Grant Likely <grant.likely at secretlab.ca>
> 
> pr_debug() calls in the 'hot' *_mask(), *_unmask(), *_ack() and
> get_irq() makes adding #define DEBUG pretty much useless.  Remove
> these calls because they completely swamp the output.
> 
> Signed-off-by: Grant Likely <grant.likely at secretlab.ca>

Yup!

Reviewed-by: Wolfram Sang <w.sang at pengutronix.de>

> ---
> 
>  arch/powerpc/platforms/52xx/mpc52xx_pic.c |   23 -----------------------
>  1 files changed, 0 insertions(+), 23 deletions(-)
> 
> 
> diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pic.c b/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> index 0a093f0..c0a9559 100644
> --- a/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> +++ b/arch/powerpc/platforms/52xx/mpc52xx_pic.c
> @@ -163,8 +163,6 @@ static void mpc52xx_extirq_mask(unsigned int virq)
>  	irq = irq_map[virq].hwirq;
>  	l2irq = irq & MPC52xx_IRQ_L2_MASK;
>  
> -	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
> -
>  	io_be_clrbit(&intr->ctrl, 11 - l2irq);
>  }
>  
> @@ -176,8 +174,6 @@ static void mpc52xx_extirq_unmask(unsigned int virq)
>  	irq = irq_map[virq].hwirq;
>  	l2irq = irq & MPC52xx_IRQ_L2_MASK;
>  
> -	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
> -
>  	io_be_setbit(&intr->ctrl, 11 - l2irq);
>  }
>  
> @@ -189,8 +185,6 @@ static void mpc52xx_extirq_ack(unsigned int virq)
>  	irq = irq_map[virq].hwirq;
>  	l2irq = irq & MPC52xx_IRQ_L2_MASK;
>  
> -	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
> -
>  	io_be_setbit(&intr->ctrl, 27-l2irq);
>  }
>  
> @@ -255,8 +249,6 @@ static void mpc52xx_main_mask(unsigned int virq)
>  	irq = irq_map[virq].hwirq;
>  	l2irq = irq & MPC52xx_IRQ_L2_MASK;
>  
> -	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
> -
>  	io_be_setbit(&intr->main_mask, 16 - l2irq);
>  }
>  
> @@ -268,8 +260,6 @@ static void mpc52xx_main_unmask(unsigned int virq)
>  	irq = irq_map[virq].hwirq;
>  	l2irq = irq & MPC52xx_IRQ_L2_MASK;
>  
> -	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
> -
>  	io_be_clrbit(&intr->main_mask, 16 - l2irq);
>  }
>  
> @@ -291,8 +281,6 @@ static void mpc52xx_periph_mask(unsigned int virq)
>  	irq = irq_map[virq].hwirq;
>  	l2irq = irq & MPC52xx_IRQ_L2_MASK;
>  
> -	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
> -
>  	io_be_setbit(&intr->per_mask, 31 - l2irq);
>  }
>  
> @@ -304,8 +292,6 @@ static void mpc52xx_periph_unmask(unsigned int virq)
>  	irq = irq_map[virq].hwirq;
>  	l2irq = irq & MPC52xx_IRQ_L2_MASK;
>  
> -	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
> -
>  	io_be_clrbit(&intr->per_mask, 31 - l2irq);
>  }
>  
> @@ -327,8 +313,6 @@ static void mpc52xx_sdma_mask(unsigned int virq)
>  	irq = irq_map[virq].hwirq;
>  	l2irq = irq & MPC52xx_IRQ_L2_MASK;
>  
> -	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
> -
>  	io_be_setbit(&sdma->IntMask, l2irq);
>  }
>  
> @@ -340,8 +324,6 @@ static void mpc52xx_sdma_unmask(unsigned int virq)
>  	irq = irq_map[virq].hwirq;
>  	l2irq = irq & MPC52xx_IRQ_L2_MASK;
>  
> -	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
> -
>  	io_be_clrbit(&sdma->IntMask, l2irq);
>  }
>  
> @@ -353,8 +335,6 @@ static void mpc52xx_sdma_ack(unsigned int virq)
>  	irq = irq_map[virq].hwirq;
>  	l2irq = irq & MPC52xx_IRQ_L2_MASK;
>  
> -	pr_debug("%s: irq=%x. l2=%d\n", __func__, irq, l2irq);
> -
>  	out_be32(&sdma->IntPend, 1 << l2irq);
>  }
>  
> @@ -613,8 +593,5 @@ unsigned int mpc52xx_get_irq(void)
>  		}
>  	}
>  
> -	pr_debug("%s: irq=%x. virq=%d\n", __func__, irq,
> -		 irq_linear_revmap(mpc52xx_irqhost, irq));
> -
>  	return irq_linear_revmap(mpc52xx_irqhost, irq);
>  }
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

-- 
  Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20090129/7d95fb5d/attachment.pgp>