[PATCH 3/3] ehea: Improve driver behaviour in low mem conditions

David Miller davem at davemloft.net
Thu Jan 22 09:47:22 EST 2009


From: Thomas Klein <tklein at de.ibm.com>
Date: Wed, 21 Jan 2009 15:49:41 +0100

> Reworked receive queue fill policies to make the driver more tolerant
> in low memory conditions.
> 
> Signed-off-by: Thomas Klein <tklein at de.ibm.com>

Applied, but there is an even better way to handle this.

You should be allocating replacement RX skbs at receive time.  And if
the RX allocation fails, you simply give the RX skb back to the chip
and do not pass it up into the stack.

This is what many ethernet drivers do to ensure that the chip never
can reach a situation where the free RX packet queue becomes empty.



More information about the Linuxppc-dev mailing list