[PATCH][v4] powerpc 44x: support for 256KB PAGE_SIZE
jwboyer at linux.vnet.ibm.com
Mon Jan 19 00:40:03 EST 2009
On Sat, Jan 17, 2009 at 08:32:25PM -0600, Milton Miller wrote:
> On Jan 16, 2009, at 9:18 AM, Yuri Tikhonov wrote:
>> On Friday, January 16, 2009 you wrote:
>>> On Jan 12, 2009, at 4:49 PM, Yuri Tikhonov wrote:
>>>> This patch adds support for 256KB pages on ppc44x-based boards.
>>>> +config STDBINUTILS
>>>> + bool "Using standard binutils settings"
>>>> + depends on 44x
>>>> + default y
>>> I think this should be
>>> config STDBINUTILS
>>> bool "Using standard binutils settings" if 44x
>>> default y
>>> that way we imply that all powerpc users are using the standard
>>> binutils instead of only those using a 44x platform. We still get the
>>> intended effect of asking the user only on 44x.
>>> I haven't looked at the resulting question or config order to see if
>>> makes sense to leave it here or put it closer to the page size.
>> I'm not sure about this. For 44x platforms - the STDBINUTILS option
>> is reasonable, because it's used in the PAGE_SIZE selection process.
>> But as regarding the other powerpcs the STDBINUTILS option will do
>> nothing, but taking a superfluous string in configs. Are you sure this
>> will be better ?
> Ok I tried this out in menuconfig. You are right that the depends on
> makes sense as it removes the option from the config file as not
> relevant. But right now to enable 256K pages one has to go to platform
> setup to find this dependency, then has to go to general setup to find
> the shmem option at the bottom of the list in the embedded/expert
> section, then finally go to the kernel options menu to finally choose
> the page size.
Which is fine with me. This is for people that really know what they're
doing, so making it harder to enable isn't really a bad thing.
More information about the Linuxppc-dev