[PATCH 2/4] powerpc: Add ppc_progress() wrapper

Paul Mackerras paulus at samba.org
Thu Jan 15 22:34:18 EST 2009


Michael Ellerman writes:

> There's quite a lot of code that does:
> 
> if (ppc_md.progress)
> 	ppc_md.progress(...)
> 
> So move that idiom into a wrapper. Having a wrapper also allows us
> to have a fallback to printk if no progress routine is specified.

It certainly used to be the case on ppc32 (and may still be) that
ppc_md.progress was called very very early, in some cases before the
MMU was set up, so we don't want to call printk from it.  Falling back
to udbg_printf would be more appropriate.

The idea of ppc_md.progress was that if you need to debug very early
boot and you have something that you can poke with absolutely minimal
setup and observe externally, you can hook that up to ppc_md.progress
and get an idea where the system is dying.  Once you get to the point
where printk works then you can just use printk.

Paul.



More information about the Linuxppc-dev mailing list