[PATCH] phylib: Fix Freescale TBI PHY detection
Andy Fleming
afleming at freescale.com
Thu Jan 15 05:20:35 EST 2009
On Jan 14, 2009, at 9:03 AM, Anton Vorontsov wrote:
>>
>> There is one thing I don't actually understand though...
>>
>> Andy, were you testing the TBI support on a hardware where PHY ID
>> != 0x0 or maybe your TBI PHY support patch (commit b31a1d8b41513b,
>> dated Tue Dec 16 15:29:15 2008) was based on a bit outdated kernel
>> version? Because according to the git timestamps, the TBI support
>> was not working since the submission.
>>
>> Just in case, the hardware I'm seeing the PHY ID == 0x0 is
>> MPC8378E-MDS.
>
> I think I got it. Probably the TBI support patch was based on the
> powerpc.git next, and the commit that broke the TBI support
> was in the net-next-2.6 tree.
>
> That explains why nobody noticed the issue.
Yeah, I dropped the ball. I saw the patch go in, thought that might
break something, but I didn't find time to look into it. Thanks for
finding and reverting this bug.
Acked-by: Andy Fleming <afleming at freescale.com>
More information about the Linuxppc-dev
mailing list