[PATCH] fsldma: print correct IRQ on mpc83xx
Peter Korsgaard
jacmet at sunsite.dk
Thu Jan 15 03:38:23 EST 2009
>>>>> "Timur" == Timur Tabi <timur at freescale.com> writes:
Timur> Peter Korsgaard wrote:
>> Why? Does it buy us anything to request_irq again for each channel?
>>
>> Now we're at it, it seems like there's a check for != NO_IRQ missing
>> in fsl_dma_chan_remove().
Timur> If the device tree doesn't specify an interrupts property in
Timur> the device channel, then I think that's an error. All the
Timur> device trees already do that. So where do you see this
Timur> problem?
Documentation/powerpc/dts-bindings/fsl/dma.txt and
The NO_IRQ check in fsldma.c:fsl_dma_chan_probe()
And it makes sense, there's no per-channel DMAC interrupts on mpc83xx.
--
Bye, Peter Korsgaard
More information about the Linuxppc-dev
mailing list