[PATCH v2] powerpc/fs_enet: Add missing irq free in error path.

Kumar Gala galak at kernel.crashing.org
Wed Jan 14 03:28:15 EST 2009


On Oct 27, 2008, at 4:46 PM, Mike Ditto wrote:

> If something goes wrong attaching to phy driver, we weren't freeing
> the IRQ.
>
> Signed-off-by: Mike Ditto <mditto at consentry.com>
> ---
> Reposting to CC netdev list.  (Thanks, Kumar)
>
> diff -r -upN 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c NEW/ 
> drivers/net/fs_enet/fs_enet-main.c
> --- 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c	2008-10-24  
> 17:54:31.000000000 -0700
> +++ NEW/drivers/net/fs_enet/fs_enet-main.c	2008-10-24  
> 17:57:03.000000000 -0700
> @@ -795,6 +795,7 @@ static int fs_enet_open(struct net_devic
>
> 	err = fs_init_phy(dev);
> 	if (err) {
> +		free_irq(fep->interrupt, dev);
> 		if (fep->fpi->use_napi)
> 			napi_disable(&fep->napi);
> 		return err;
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Dave,

This seems to have gotten lost in the shuffle.  Can you please apply.

- k



More information about the Linuxppc-dev mailing list