[PATCH 1/5] powerpc: booke: Don't hard-code size of struct tlbcam

[Kumar Gala]

On Dec 9, 2008, at 8:26 AM, Josh Boyer wrote:

> On Mon,  8 Dec 2008 19:34:55 -0800
> Trent Piepho <tpiepho at freescale.com> wrote:
>
>> Some assembly code in head_fsl_booke.S hard-coded the size of  
>> struct tlbcam
>> to 20 when it indexed the TLBCAM table.  Anyone changing the size  
>> of struct
>> tlbcam would not know to expect that.
>>
>> The kernel already has a system to get the size of C structures into
>> assembly language files, asm-offsets, so let's use it.
>>
>> The definition of the struct gets moved to a header, so that asm- 
>> offsets.c
>> can include it.
>
> I don't mean to be overly picky, but your patch subjects and changelog
> descriptions are a bit wrong.  This series pertains to FSL BookE  
> chips,
> not BookE in general.  There are other variants of BookE, such as 4xx.
>
> If you could keep that in mind for future revisions, I'd appreciate
> it.  Something like:
>
> [PATCH] powerpc/fsl-booke:
>
> or something similar would be a bit more correct.  Unless you really
> are changing something global to all BookE processors (which is sort  
> of
> rare at the moment).

I fixed this in the actually commit ;)

- k