[PATCH] [POWERPC] pasemi: ioremap/iounmap balance and failure handling
Benjamin Herrenschmidt
benh at kernel.crashing.org
Wed Jan 7 11:50:55 EST 2009
> +
> iob_regs = map_onedev(iob_pdev, 0);
> + if (iob_regs == NULL)
> + printk(KERN_WARNING "pasemi_dma_init: Can't ioremap I/O Bridge registers\n");
>
> dma_pdev = pci_get_device(PCI_VENDOR_ID_PASEMI, 0xa007, NULL);
> if (!dma_pdev) {
> BUG();
> printk(KERN_WARNING "Can't find DMA controller\n");
> err = -ENODEV;
> - goto out;
> + goto out_unmap;
> }
None of that will be reached due to the previous BUG :-)
Cheers,
Ben.
More information about the Linuxppc-dev
mailing list