[PATCH] powerpc/8313erdb: fix kernel crash

[Li Yang]

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org] 
> Sent: Tuesday, January 06, 2009 12:25 AM
> To: Li Yang-R58472
> Cc: linuxppc-dev at ozlabs.org
> Subject: Re: [PATCH] powerpc/8313erdb: fix kernel crash
> 
> 
> On Jan 5, 2009, at 4:47 AM, Li Yang wrote:
> 
> > Probe the new mdio node added by b31a1d8b.  Fix kernel 
> panic problem 
> > when gianfar driver wants to get the of_platform_device of 
> that mdio.
> >
> > Signed-off-by: Li Yang <leoli at freescale.com>
> > ---
> > arch/powerpc/boot/dts/mpc8313erdb.dts |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/ 
> > boot/dts/mpc8313erdb.dts index d4df8b6..917d466 100644
> > --- a/arch/powerpc/boot/dts/mpc8313erdb.dts
> > +++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
> > @@ -222,7 +222,7 @@
> > 			cell-index = <1>;
> > 			device_type = "network";
> > 			model = "eTSEC";
> > -			compatible = "gianfar";
> > +			compatible = "gianfar", "simple-bus";
> > 			reg = <0x25000 0x1000>;
> > 			local-mac-address = [ 00 00 00 00 00 00 ];
> > 			interrupts = <34 0x8 33 0x8 32 0x8>;
> 
> This isn't correct at all.  Not sure what the panic is but 
> adding "simple-bus" isn't correct.

The panic is caused because mdio node associated with this TSEC is not
probed.  It may be better to have more exception check in the gianfar
driver rather than panic directly.  Anyway, mdio need to be probed as
of_platform_device for it to work correctly with phy driver.

I'm not sure if adding "simple-bus" is the preferred solution.  It is
being discussed in a separate mail thread.

- Leo