[PATCH v2 3/4] powerpc/fsl_pci: Add MPC83xx PCI-E controller RCmode support

Liu Dave DaveLiu at freescale.com
Mon Jan 5 19:18:26 EST 2009


> +static void __iomem *mpc83xx_pcie_remap_cfg(struct pci_bus *bus,
> +				    unsigned int devfn, int offset)
> +{
> +	struct pci_controller *hose = bus->sysdata;
> +	struct mpc83xx_pcie *pcie = hose->dn->data;
> +	u8 bus_no = bus->number - hose->first_busno;
> +	u32 dev_base = bus_no << 20 | devfn << 12;

Hello Anton,

There is one bug for the bus/device number shift according to the latest
83xx UM. The shift should be

dev_base = (bus_no << 24) | (devfn << 16);

You can download the latest MPC8315 UM as reference from
http://www.freescale.com.

AFAIK, you will work on the u-boot for 83xx PEX, Any question forward
to Jerry Huang (in cc). I think he should have some update for PEX.

Thanks,
Dave




More information about the Linuxppc-dev mailing list