[PATCH 1/2] powerpc: G4 oprofile: variable number of counters

Octavian Purdila opurdila at ixiacom.com
Tue Feb 24 23:09:57 EST 2009


>>  static int oprofile_running;
>> -static u32 mmcr0_val, mmcr1_val, mmcr2_val;
>> +static u32 mmcr0_val, mmcr1_val, mmcr2_val, ctrs;
>
>This may be static but it's still a global scope as far as kernel
>symbols are concerned. Care to give it a slightly better name ? num_pmcs
>would probably be already more telling.

Sure. v2 will follow, with s/ctrs/num_pmcs/.

Thanks,
tavi



More information about the Linuxppc-dev mailing list