[PATCH 2/2] Make sure we copy all cpu_spec features except PMC related ones

Dave Kleikamp shaggy at linux.vnet.ibm.com
Tue Feb 24 00:28:43 EST 2009


On Mon, 2009-02-23 at 13:25 +1100, Michael Ellerman wrote:
> When identify_cpu() is called a second time with a logical PVR, it
> only copies a subset of the cpu_spec fields so as to avoid overwriting
> the performance monitor fields that were initialized based on the
> real PVR.
> 
> However some of the other, non performance monitor related fields are
> also not copied:
>  * pvr_mask
>  * pvr_value
>  * mmu_features
>  * machine_check
> 
> The fact that pvr_mask is not copied can result in show_cpuinfo()
> showing the cpu as "unknown", if we override an unknown PVR with a
> logical one - as reported by Shaggy.
> 
> So change the logic to copy all fields, and then put back the PMC
> related ones in the case that we're overwriting a real PVR with a
> logical one.
> 
> Signed-off-by: Michael Ellerman <michael at ellerman.id.au>

Acked-by: Dave Kleikamp <shaggy at linux.vnet.ibm.com>

-- 
David Kleikamp
IBM Linux Technology Center




More information about the Linuxppc-dev mailing list