[PATCH] Only disable/enable LSI interrupts in EEH
Mike Mason
mmlnx at us.ibm.com
Fri Feb 13 03:06:51 EST 2009
Michael Ellerman wrote:
> On Tue, 2009-02-10 at 13:12 -0800, Mike Mason wrote:
>> I'm resubmitting this patch with a couple changes
>> suggested by Michael Ellerman. 1) the new functions
>> should be static, and 2) some people may object to
>> including unrelated formating changes.
>>
>> =========================================================
>>
>> The EEH code disables and enables interrupts during the
>> device recovery process. This is unnecessary for MSI
>> and MSI-X interrupts because they are effectively disabled
>> by the DMA Stopped state when an EEH error occurs. The
>> current code is also incorrect for MSI-X interrupts. It
>> doesn't take into account that MSI-X interrupts are tracked
>> in a different way than LSI/MSI interrupts. This patch
>> ensures only LSI interrupts are disabled/enabled.
>>
>> Signed-off-by: Mike Mason <mmlnx at us.ibm.com>
>> Acked-by: Linas Vepstas <linasvepstas at gmail.com>
>
>
> Looks good. Assuming you've tested it :)
Yes, it's been tested with network devices that use LSI, MSI and MSI-X interrupts. All recovered fine.
>
> Acked-by: Michael Ellerman <michael at ellerman.id.au>
>
>
More information about the Linuxppc-dev
mailing list