[PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

Timur Tabi timur at freescale.com
Wed Feb 11 01:59:57 EST 2009


On Fri, Feb 6, 2009 at 8:00 AM, Timur Tabi <timur at freescale.com> wrote:
> The i2c_wait() function is using wait_event_interruptible_timeout() to wait for
> the I2C controller to signal that it has completed an I2C bus operation.  If
> the process that causes the I2C operation terminated abruptly, the wait will
> be interrupted, returning an error.  It is better to let the I2C operation
> finished before the process exits.
>
> It is safe to use wait_event_timeout() instead, because the timeout will allow
> the process to exit if the I2C bus hangs.  It's also better to allow the
> I2C operation to finish, because unacknowledged I2C operations can cause the
> I2C bus to hang.
>
> Signed-off-by: Timur Tabi <timur at freescale.com>

Jean,

Could you pick up this patch for 2.6.30?

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the Linuxppc-dev mailing list